Hi On Tue, Aug 25, 2026 at 7:07 PM Mark Cave-Ayland <[email protected]> wrote: > > On 18/08/2026 12:10, Marc-André Lureau wrote: > > > The getter and setter use visit_type_size, not visit_type_int. > > > > Fixes: 983768431676 ("hostmem-file: add "align" option") > > Signed-off-by: Marc-André Lureau <[email protected]> > > --- > > backends/hostmem-file.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c > > index 52b62f715334..39a46d353839 100644 > > --- a/backends/hostmem-file.c > > +++ b/backends/hostmem-file.c > > @@ -275,7 +275,7 @@ file_backend_class_init(ObjectClass *oc, const void > > *data) > > file_memory_backend_get_discard_data, > > file_memory_backend_set_discard_data); > > object_class_property_add_str(oc, "mem-path", > > get_mem_path, set_mem_path); > > - object_class_property_add(oc, "align", "int", > > + object_class_property_add(oc, "align", "size", > > file_memory_backend_get_align, > > file_memory_backend_set_align, > > NULL, NULL); > > This looks right, however I also notice that both > file_memory_backend_get_align() and file_memory_backend_set_align() > assign the value to uint64_t - is it worth fixing at the same time? > > Anyhow: > Reviewed-by: Mark Cave-Ayland <[email protected]>
Since the underlying type is uint64, let's use that for the visitor as well. thanks > > > ATB, > > Mark. >
