> +bool virtio_net_setup(void)
> +{
> + switch (virtio_get_device()->ipl_type) {
> + case S390_IPL_TYPE_CCW:
> + return virtio_ccw_net_setup();
> + default:
> + return false;
> + }
> +}
This patch is largely renaming, but this does seem to have a subtle
functional change right here.
AFAICT before this patch attempting to netboot with anything other than
a ccw device would hit
IPL_assert(iplb.pbt == S390_IPL_TYPE_CCW, "IPL_TYPE_CCW expected");
Now, we will never call virtio_ccw_net_setup(), return false and instead
bail out with
"No virtio net device found."
That is new behavior for !IPL_TYPE_CCW after this patch. For
IPL_TYPE_PCI, patch 4 will change the behavior again.
That's not a deal-breaker, but I do think it's worth a mention in the
commit message. I then also wonder if the message
"No virtio net device found"
would be more accurate if it instead read something like:
"No supported virtio net device found"
Thanks,
Matt
