On 25/8/26 21:09, Marc-André Lureau wrote:
Those functions are only used when CONFIG_HMP, compile them out, and add
conditions for the calling code.

Reviewed-by: Dr. David Alan Gilbert <[email protected]>
Signed-off-by: Marc-André Lureau <[email protected]>
---
  monitor/hmp.c       | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
  monitor/monitor.c   | 49 -------------------------------------------------
  util/error-report.c |  3 ++-
  util/qemu-print.c   |  6 ++++++
  4 files changed, 57 insertions(+), 50 deletions(-)


diff --git a/util/error-report.c b/util/error-report.c
index 78ccb6ea608e..111bfe29020b 100644
--- a/util/error-report.c
+++ b/util/error-report.c
@@ -35,10 +35,11 @@ const char *error_guest_name;
  static int G_GNUC_PRINTF(2, 0)
  error_vprintf_mon(MonitorHMP *hmp, const char *fmt, va_list ap)
  {
+#ifdef CONFIG_HMP
      if (hmp) {

Would this work?

        if (IS_ENABLED(CONFIG_HMP) && hmp) {

          return monitor_hmp_vprintf(hmp, fmt, ap);
      }
-
+#endif
      return vfprintf(stderr, fmt, ap);
  }

Reply via email to