On 24/8/26 14:29, Daniel P. Berrangé wrote:
Expand the text a bit to make the new syntax more explicit and point
users to the man page for further info.
Reported-by: Peter Maydell <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
---
system/vl.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/system/vl.c b/system/vl.c
index 061cbdf860..d5b5392569 100644
--- a/system/vl.c
+++ b/system/vl.c
@@ -3239,8 +3239,11 @@ void qemu_init(int argc, char **argv)
default_monitor = 0;
break;
case QEMU_OPTION_mon:
- warn_report_once("'-mon' is deprecated, use '-object' with "
- "'monitor-hmp' or 'monitor-qmp' types
instead");
+ warn_report_once("'-mon' is deprecated. Switch to either "
+ "'-object monitor-hmp,id=ID,chardev=CHR-ID' "
+ "or '-object monitor-qmp,id=qmpNN,chardev=CHR-ID'
"
+ "instead. See '-object' docs in 'qemu(1)' for
further "
+ "configuration guidance.");
Looking at commit 58b70f21ba6 ("docs: mark '-mon' as deprecated in
favour of -object") I'm not sure this is a good idea to document
'-object monitor-qmp' at all on CLI help. CLI users looking at
help output are likely users of '-mon' for HMP. My 2 cents.
if (!qemu_opts_parse_noisily(qemu_find_opts("mon"), optarg,
true)) {
exit(1);
