On Mon, Aug 31, 2026 at 9:52 AM Markus Armbruster <[email protected]> wrote:
>
> John Snow <[email protected]> writes:
>
> > Signed-off-by: John Snow <[email protected]>
> > ---
> >  qapi/block.json | 41 +++++++++++++++++------------------------
> >  1 file changed, 17 insertions(+), 24 deletions(-)
> >
> > diff --git a/qapi/block.json b/qapi/block.json
> > index 46955bbb3e3..189f2e28204 100644
> > --- a/qapi/block.json
> > +++ b/qapi/block.json
>
> [...]
>
> > @@ -314,12 +310,11 @@
> >
> >  ##
> >  # @blockdev-change-medium:
> > -#
> > -# Changes the medium inserted into a block device by ejecting the
> > -# current medium and loading a new image file which is inserted as the
> > -# new medium (this command combines `blockdev-open-tray`,
> > -# `blockdev-remove-medium`, `blockdev-insert-medium` and
> > -# `blockdev-close-tray`).
> > +#     Changes the medium inserted into a block device by ejecting the
> > +#     current medium and loading a new image file which is inserted as
> > +#     the new medium (this command combines `blockdev-open-tray`,
> > +#     `blockdev-remove-medium`, `blockdev-insert-medium` and
> > +#     `blockdev-close-tray`).
> >  #
> >  # @device: Block device name
> >  #
>
> Not sure the parenthesis belongs into the intro.
>
> I'm okay with keeping this hunk anyway.

In this case, it will be fine as this is a command and the precise
split between intro and details is a lot less crucial. It can be
adjusted later at our leisure.

--js


Reply via email to