Hi Mayuresh,

Thanks for fixing this.

While testing related RISC-V PMU changes, I noticed the same read-back
issue reported by Gong: rmw_sip64() also needs to include LCOFI in its
read mask.

I also noticed that adding MIP_LCOFIP to the static masks exposes bit
13 when Sscofpmf is disabled. The specification requires sip.LCOFIP
and sie.LCOFIE to be read-only zero in that configuration. Would it
make sense to condition these masks on ext_sscofpmf?

For the virtual-interrupt path, Smcdeleg requires both mvip and mvien
LCOFI when Smcdeleg, Sscofpmf, and Smaia are implemented. Is mvien
support planned as a follow-up?

I have local TCG tests covering the base, extension-disabled, and
virtual-interrupt cases and can share them if useful.

This also appears to address:
https://gitlab.com/qemu-project/qemu/-/work_items/3969

Thanks,
Tiancheng

Reply via email to