On Sat, 15 Aug 2026 at 21:37, Richard Henderson <[email protected]> wrote: > > The driver for this RFC is > https://lore.kernel.org/qemu-devel/[email protected]/ > > Based-on: [email protected] > ("[PATCH 00/23] target/riscv: Reorg vector load/store") > > But also merged to master, so for avoidance of doubt: > https://gitlab.com/rth7680/qemu/-/commits/tcg-probe > > Convert probe_access_full, probe_access_flags, and the backend tlb_fill > hooks, but not (yet) probe_access itself. I'm less certain about that, > since its uses are (1) less complicated and (2) there's also a path, > which I can't prove isn't used but neither can I find, which avoids > both watchpoints and notdirty pages. > > I've tweaked the riscv pmp check to use the new parameters. > The similar Armv8-M code is a bit more complicated to push through, > and I need to study it a bit more.
I think this is a good API change, and getting rid of the confusing "probe with size 0" is definitely worthwhile. I think we need to be careful as we do this refactor about places where we calculate a "last" address via "addr + size - 1" and that might wrap around; I've left comments where I think that might happen. thanks -- PMM
