Daniel P. Berrangé <[email protected]> writes: > The default checkpatch.pl output includes a lot of "progress" > information... > > NN/MM Checking commit HASH (SUBJECT) > total: 0 errors, 0 warnings, 105 lines checked > > for large patch series, this results in alot of noise from > clean patches (which are the common case), obscuring the > info about the patch violations. > > Since the alerts from gitlab job failures only include the > last few lines of log output, we want the checkpatch.pl > output to be highly relevant to the failure. > > We previously addressed that by adding use of the --terse > flag in 7025111a199b97ae806817788bec50f456c47d85, but that > made the output a bit too terse. It no longer prints the > offending line of code, so understanding the CI job failure > now requires manually re-running checkpatch.pl locally. > > Using the '--quiet' flag gets rid of the "Check commit HASH.." > messages which create noise, while adding '--emacs' causes > the WARNING/ERROR message lines to include the commit hash. > > This is a more useful tradeoff for the CI job logs. The > output is limited to only patches which include code > violations, while still including the offending lines of > code in the output. > > Signed-off-by: Daniel P. Berrangé <[email protected]> > --- > .gitlab-ci.d/check-patch.py | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/.gitlab-ci.d/check-patch.py b/.gitlab-ci.d/check-patch.py > index be13e6f77d..45be77295d 100755 > --- a/.gitlab-ci.d/check-patch.py > +++ b/.gitlab-ci.d/check-patch.py > @@ -46,7 +46,11 @@ > > print("\nChecking all commits since %s...\n" % ancestor, flush=True) > > -ret = subprocess.run(["scripts/checkpatch.pl", "--terse", ancestor + "..."]) > +# We don't want "noise" for clean patches, but do want to see > +# the full commit hash for each violation, along with the > +# offending patch content > +ret = subprocess.run(["scripts/checkpatch.pl", "--emacs", "--quiet", > + ancestor + "..."]) > > if ret.returncode != 0: > print(" ❌ FAIL one or more commits failed scripts/checkpatch.pl")
Reviewed-by: Alex Bennée <[email protected]> -- Alex Bennée Virtualisation Tech Lead @ Linaro
