On Mon, Aug 31, 2026 at 12:01:48PM +0200, Denis V. Lunev wrote: > From: Denis V. Lunev <[email protected]> > > qio_channel_websock_handshake_send() treats every negative return from > qio_channel_write() as fatal and passes err to error_get_pretty(). > QIO_CHANNEL_ERR_BLOCK is negative but leaves err NULL, so a socket > which cannot take the response immediately crashes QEMU before the > client has authenticated. > > Keep the G_IO_OUT watch armed and retry instead. > > Fixes: 2d1d0e70cf3e ("io: add QIOChannelWebsock class") > Cc: [email protected] > Cc: Daniel P. Berrangé <[email protected]> > Cc: Marc-André Lureau <[email protected]> > Signed-off-by: Denis V. Lunev <[email protected]> > --- > io/channel-websock.c | 5 +++++ > 1 file changed, 5 insertions(+)
Reviewed-by: Daniel P. Berrangé <[email protected]> With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
