Gilles Grimaud <[email protected]> writes:

> From: gilles grimaud <[email protected]>
>
> This RFC adds a Raspberry Pi Pico / RP2040 machine to QEMU.
>
> The work continues the RP2040/Pico RFC posted by Alex Bennee in 2022:
>
>   https://patchew.org/QEMU/20220110175104.2908956-1-alex.bennee%40linaro.org/
>
> The target is intended primarily for debugging bare-metal Pico firmware and
> for running firmware tests in CI without physical hardware.  It provides a
> functional, test-oriented model rather than a cycle-accurate RP2040 model.
>
> The machine supports two boot paths.  The default synthetic ROM implements
> the RP2040 boot protocol and selected ROM service tables, with optional
> QEMU-accelerated helpers for firmware testing.  Alternatively, users may
> supply an RP2040 mask ROM image with -bios to exercise the modeled hardware
> path.  QEMU does not ship that image, and USB BOOTSEL mass storage is not
> currently supported.

I've finished my first pass through, I'll re-review once you post v3.
However some general points:

  - checkpatch everything
  - format commit messages
  - reduce duplication
  - ensure only one architectural features being modified per patch 

I've also included our experimental AI reviewer so takes it's
suggestions with a pinch of salt:

  https://patchpilot.linaro.org/run/b132da76b734#stage=review

but it might be worth a read through none the less.

>
<snip>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Reply via email to