On Wed, Sep 02, 2026 at 07:15:40PM -0300, Fabiano Rosas wrote:
> The output of 'info migrate_parameters' includes units of measurement
> for a few parameters. This is convenient for a user. It also requires
> every parameter to be individually listed in the
> hmp_migrate_set_parameter() function, which in turn requires the
> MigrationParameter (singular) enum to exist. While the latter is not
> bothersome at all, the former is.
> 
> From a development and maintenance perspective, having a list of
> parameters explicitly written in several parts of the code brings
> several annoyances: conflicts during rebase, multiple extra hits when
> grepping, requires contributors to search for every location a change
> needs to be mirrored to, etc.
> 
> Remove the units from the output so we can write this code in a more
> convenient way. The HMP output is not part of any ABI.
> 
> Also remove quotes from around the TLS options strings as this is
> inconsistent with all the other strings.
> 
> Change block-bitmap-mapping format to a single line. This requires
> updating one of the iotests to match.
> 
> Signed-off-by: Fabiano Rosas <[email protected]>

HMP info commands are less of a worry.  I think this is ok, but I didn't
check the block layer details.  From migration side:

Acked-by: Peter Xu <[email protected]>

-- 
Peter Xu


Reply via email to