The end-of-month rollover was untested, for any of the lengths the calendar gives a month.
Signed-off-by: Emmanuel Blot <[email protected]> --- tests/qtest/ds1339-test.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+) diff --git a/tests/qtest/ds1339-test.c b/tests/qtest/ds1339-test.c index 8c144579e6..7eec163049 100644 --- a/tests/qtest/ds1339-test.c +++ b/tests/qtest/ds1339-test.c @@ -14,6 +14,7 @@ /* DS1339 register map */ #define DS1339_SECONDS 0x00 +#define DS1339_DATE 0x04 #define DS1339_MONTH 0x05 #define DS1339_YEAR 0x06 #define DS1339_ALARM1 0x07 @@ -169,6 +170,61 @@ static void test_eosc_restart(void *obj, void *data, QGuestAllocator *alloc) g_assert_cmphex(resp[6], ==, 0x31); } +/* Program 23:59:59 on the last day of a month and run the clock past it. */ +static void check_month_rollover(QI2CDevice *i2cdev, + uint8_t date, uint8_t month, uint8_t year, + uint8_t next_date, uint8_t next_month, + uint8_t next_year) +{ + const uint8_t tod[7] = { 0x59, 0x59, 0x23, 0x01, date, month, year }; + uint8_t resp[7]; + unsigned idx; + + i2c_write_block(i2cdev, DS1339_SECONDS, tod, sizeof(tod)); + + for (idx = 0; idx < 50; idx++) { + if (i2c_get8(i2cdev, DS1339_DATE) != date) { + break; + } + g_usleep(100 * 1000); + } + + i2c_read_block(i2cdev, DS1339_SECONDS, resp, sizeof(resp)); + g_assert_cmphex(resp[4], ==, next_date); + g_assert_cmphex(resp[5] & 0x1f, ==, next_month); + g_assert_cmphex(resp[6], ==, next_year); +} + +/* A 31-day month rolls over to the first of the next. */ +static void test_month_31_days(void *obj, void *data, QGuestAllocator *alloc) +{ + check_month_rollover((QI2CDevice *)obj, + 0x31, 0x01, 0x23, 0x01, 0x02, 0x23); +} + +/* A 30-day month rolls over to the first of the next. */ +static void test_month_30_days(void *obj, void *data, QGuestAllocator *alloc) +{ + check_month_rollover((QI2CDevice *)obj, + 0x30, 0x04, 0x23, 0x01, 0x05, 0x23); +} + +/* Outside a leap year, February rolls over after the 28th. */ +static void test_month_28_days(void *obj, void *data, QGuestAllocator *alloc) +{ + check_month_rollover((QI2CDevice *)obj, + 0x28, 0x02, 0x23, 0x01, 0x03, 0x23); +} + +/* In a leap year the 28th is not the last day of February. */ +static void test_month_29_days(void *obj, void *data, QGuestAllocator *alloc) +{ + QI2CDevice *i2cdev = (QI2CDevice *)obj; + + check_month_rollover(i2cdev, 0x28, 0x02, 0x24, 0x29, 0x02, 0x24); + check_month_rollover(i2cdev, 0x29, 0x02, 0x24, 0x01, 0x03, 0x24); +} + /* The Century bit is guest-writable and survives an oscillator restart. */ static void test_century_bit(void *obj, void *data, QGuestAllocator *alloc) { @@ -314,6 +370,10 @@ static void ds1339_register_nodes(void) qos_add_test("eosc-restart", "ds1339", test_eosc_restart, NULL); qos_add_test("stopped-reserved-bits", "ds1339", test_stopped_reserved_bits, NULL); + qos_add_test("month-28-days", "ds1339", test_month_28_days, NULL); + qos_add_test("month-29-days", "ds1339", test_month_29_days, NULL); + qos_add_test("month-30-days", "ds1339", test_month_30_days, NULL); + qos_add_test("month-31-days", "ds1339", test_month_31_days, NULL); qos_add_test("century-bit", "ds1339", test_century_bit, NULL); qos_add_test("century-write-no-toggle", "ds1339", test_century_write_no_toggle, NULL); -- 2.50.1
