The getter and setter use visit_type_size, not visit_type_int.
Since the underlying type is uint32, switch to that.
Fixes: 8ec1e4f1ef97 ("ppc/pnv: add phb-id/chip-id PnvPHB3RootBus properties")
Fixes: b7c1750dc440 ("ppc/pnv: add phb-id/chip-id PnvPHB4RootBus properties")
Reviewed-by: Mark Cave-Ayland <[email protected]>
Signed-off-by: Marc-André Lureau <[email protected]>
---
hw/pci-host/pnv_phb3.c | 12 ++++++------
hw/pci-host/pnv_phb4.c | 12 ++++++------
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/hw/pci-host/pnv_phb3.c b/hw/pci-host/pnv_phb3.c
index 4ffdb4ce31ae..db061c134e95 100644
--- a/hw/pci-host/pnv_phb3.c
+++ b/hw/pci-host/pnv_phb3.c
@@ -1130,7 +1130,7 @@ static void pnv_phb3_root_bus_get_prop(Object *obj,
Visitor *v,
void *opaque, Error **errp)
{
PnvPHB3RootBus *bus = PNV_PHB3_ROOT_BUS(obj);
- uint64_t value = 0;
+ uint32_t value = 0;
if (strcmp(name, "phb-id") == 0) {
value = bus->phb_id;
@@ -1138,7 +1138,7 @@ static void pnv_phb3_root_bus_get_prop(Object *obj,
Visitor *v,
value = bus->chip_id;
}
- visit_type_size(v, name, &value, errp);
+ visit_type_uint32(v, name, &value, errp);
}
static void pnv_phb3_root_bus_set_prop(Object *obj, Visitor *v,
@@ -1147,9 +1147,9 @@ static void pnv_phb3_root_bus_set_prop(Object *obj,
Visitor *v,
{
PnvPHB3RootBus *bus = PNV_PHB3_ROOT_BUS(obj);
- uint64_t value;
+ uint32_t value;
- if (!visit_type_size(v, name, &value, errp)) {
+ if (!visit_type_uint32(v, name, &value, errp)) {
return;
}
@@ -1164,12 +1164,12 @@ static void pnv_phb3_root_bus_class_init(ObjectClass
*klass, const void *data)
{
BusClass *k = BUS_CLASS(klass);
- object_class_property_add(klass, "phb-id", "int",
+ object_class_property_add(klass, "phb-id", "uint32",
pnv_phb3_root_bus_get_prop,
pnv_phb3_root_bus_set_prop,
NULL, NULL);
- object_class_property_add(klass, "chip-id", "int",
+ object_class_property_add(klass, "chip-id", "uint32",
pnv_phb3_root_bus_get_prop,
pnv_phb3_root_bus_set_prop,
NULL, NULL);
diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c
index 705a5bcf074f..9acaf4c0c2f5 100644
--- a/hw/pci-host/pnv_phb4.c
+++ b/hw/pci-host/pnv_phb4.c
@@ -1727,7 +1727,7 @@ static void pnv_phb4_root_bus_get_prop(Object *obj,
Visitor *v,
void *opaque, Error **errp)
{
PnvPHB4RootBus *bus = PNV_PHB4_ROOT_BUS(obj);
- uint64_t value = 0;
+ uint32_t value = 0;
if (strcmp(name, "phb-id") == 0) {
value = bus->phb_id;
@@ -1735,7 +1735,7 @@ static void pnv_phb4_root_bus_get_prop(Object *obj,
Visitor *v,
value = bus->chip_id;
}
- visit_type_size(v, name, &value, errp);
+ visit_type_uint32(v, name, &value, errp);
}
static void pnv_phb4_root_bus_set_prop(Object *obj, Visitor *v,
@@ -1744,9 +1744,9 @@ static void pnv_phb4_root_bus_set_prop(Object *obj,
Visitor *v,
{
PnvPHB4RootBus *bus = PNV_PHB4_ROOT_BUS(obj);
- uint64_t value;
+ uint32_t value;
- if (!visit_type_size(v, name, &value, errp)) {
+ if (!visit_type_uint32(v, name, &value, errp)) {
return;
}
@@ -1761,12 +1761,12 @@ static void pnv_phb4_root_bus_class_init(ObjectClass
*klass, const void *data)
{
BusClass *k = BUS_CLASS(klass);
- object_class_property_add(klass, "phb-id", "int",
+ object_class_property_add(klass, "phb-id", "uint32",
pnv_phb4_root_bus_get_prop,
pnv_phb4_root_bus_set_prop,
NULL, NULL);
- object_class_property_add(klass, "chip-id", "int",
+ object_class_property_add(klass, "chip-id", "uint32",
pnv_phb4_root_bus_get_prop,
pnv_phb4_root_bus_set_prop,
NULL, NULL);
--
2.55.0.543.g5ebe2ebe4ea8
