Am Mi., 9. Sept. 2026 um 09:33 Uhr schrieb Manos Pitsidianakis <[email protected]>: > > On Mon, 31 Aug 2026 10:43, Alexander Mikhalitsyn <[email protected]> > wrote: > >Am Mo., 31. Aug. 2026 um 09:41 Uhr schrieb Manos Pitsidianakis > ><[email protected]>: > >> > > > >Dear Manos, > > > >> Hi Alexander, so sorry for the massive delay but I'm on PTO for a big > >> part of August and some of September. Your series is on my priorities > >> as soon as I return. > > > >ah, then sorry for bothering you during PTO ;-) > >Have a good time! > > > >Kind regards, > >Alex >
Dear Manos, > I think this series is now fully reviewed, I will rebase against master > and send a pull request. Thank you very much for all the input and reviews! Kind regards, Alex > > Thanks! > > > > >> > >> On Mon, Aug 31, 2026 at 10:27 AM Alexander Mikhalitsyn > >> <[email protected]> wrote: > >> > > >> > Am Mo., 3. Aug. 2026 um 10:12 Uhr schrieb Alexander Mikhalitsyn > >> > <[email protected]>: > >> > > > >> > > From: Alexander Mikhalitsyn <[email protected]> > >> > > > >> > > Dear friends, > >> > > > >> > > This patchset is aimed to support virtio-sound live migration and > >> > > based on > >> > > pre-existing Volker Rümelin's patches from qemu-devel lists [1]. I > >> > > tried > >> > > to ask > >> > > (https://lore.kernel.org/qemu-devel/[email protected]/) > >> > > if Volker is going to continue his work on this, but received no reply > >> > > so I > >> > > just decided to go forward: take his patches, rebase and resend. Of > >> > > course, > >> > > I kept all authorship/tags so I hope that it is fine. > >> > > > >> > > Testing. > >> > > > >> > > I manually validated this with Ubuntu 24.04 Desktop VM and found no > >> > > issues. > >> > > Also, it was validated with CI > >> > > (https://gitlab.com/mihalicyn/qemu/-/pipelines/2626702088). > >> > > > >> > > Original patchset: > >> > > https://lore.kernel.org/qemu-devel/[email protected] > >> > > [1] > >> > > > >> > > Git tree: > >> > > https://gitlab.com/mihalicyn/qemu/-/commits/virtio-sound-migration > >> > > > >> > > Changelog for version 5: > >> > > - rebased > >> > > - added RWB tags > >> > > > >> > > Changelog for version 4: > >> > > - addressed review feedback from Marc-André Lureau > >> > > - and from Manos Pitsidianakis > >> > > *there is a detailed changelog under each commit message* > >> > > > >> > > Changelog for version 3: > >> > > - addressed review feedback from Marc-André Lureau: > >> > > - drop VirtIOSoundPCMStream's id field (unused) > >> > > - resurrected error_report(..) in virtio_snd_pcm_start_stop() > >> > > - fixes in "hw/audio/virtio-sound: add stream state variable" > >> > > [ please, look in commit message for details ] > >> > > - added "hw/audio/virtio-sound: remove channel positions field > >> > > from VirtIOSoundPCMStream" > >> > > - fixes in "hw/audio/virtio-sound: add missing vmstate fields" > >> > > [ details in commit message ] > >> > > > >> > > Changelog for version 2: > >> > > - no code changes (only commit messages) > >> > > followed suggestions from Daniel P. Berrangé (thanks, Daniel!) > >> > > https://lore.kernel.org/qemu-devel/[email protected]/ > >> > > and added some extra details about what I did with the original > >> > > patches during rebase (for some of them it was simpler and less error > >> > > prone to just drop changes and reimplement them by following the idea > >> > > of the patch, cause base code has changed significantly). > >> > > > >> > > Changelog relative to the original Volker Rümelin's submission: > >> > > - rebased: > >> > > - "hw/audio/virtio-sound: return correct command response size" > >> > > was dropped as it was already merged > >> > > - "hw/audio/virtio-sound: fix segmentation fault in tx/rx xfer > >> > > handler" > >> > > was dropped as it seems to be replaced with another fix > >> > > > >> > > https://github.com/qemu/qemu/commit/731655f87f319fd06f27282c6cafbc2467ac8045 > >> > > - I had to drop all pre-existing Reviewed-by tags cause it was > >> > > 2 years since > >> > > this patchset was sent and reviewed and I did a quite > >> > > significant code changes > >> > > during rebase > >> > > > >> > > Kind regards, > >> > > Alex > >> > > > >> > > Alexander Mikhalitsyn (2): > >> > > hw/audio/virtio-sound: remove channel positions field from > >> > > VirtIOSoundPCMStream > >> > > hw/audio/virtio-sound: drop unused struct > >> > > VirtIOSoundPCMStream.flushing field > >> > > > >> > > Volker Rümelin (8): > >> > > hw/audio/virtio-sound: remove command and stream mutexes > >> > > hw/audio/virtio-sound: allocate an array of streams > >> > > hw/audio/virtio-sound: free all stream buffers on reset > >> > > hw/audio/virtio-sound: split out virtio_snd_pcm_start_stop() > >> > > hw/audio/virtio-sound: add stream state variable > >> > > hw/audio/virtio-sound: introduce virtio_snd_pcm_open() > >> > > hw/audio/virtio-sound: introduce virtio_snd_set_active() > >> > > hw/audio/virtio-sound: add missing vmstate fields > >> > > > >> > > hw/audio/virtio-snd.c | 696 ++++++++++++++++++++-------------- > >> > > include/hw/audio/virtio-snd.h | 26 +- > >> > > 2 files changed, 414 insertions(+), 308 deletions(-) > >> > > > >> > > -- > >> > > 2.47.3 > >> > > > >> > > >> > Gentle ping. > >> > >> -- > >> Manos Pitsidianakis > >> Emulation and Virtualization Engineer at Linaro Ltd
