John Snow <[email protected]> writes:

> Signed-off-by: John Snow <[email protected]>
> ---
>  qapi/crypto.json | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/qapi/crypto.json b/qapi/crypto.json
> index 5e395bc10c7..f85d1cebed3 100644
> --- a/qapi/crypto.json
> +++ b/qapi/crypto.json
> @@ -10,10 +10,10 @@
>  
>  ##
>  # @QCryptoTLSCredsEndpoint:
> -#
> -# The type of network endpoint that will be using the credentials.
> -# Most types of credential require different setup / structures
> -# depending on whether they will be used in a server versus a client.
> +#     The type of network endpoint that will be using the credentials.
> +#     Most types of credential require different setup / structures
> +#     depending on whether they will be used in a server versus a
> +#     client.
>  #
>  # @client: the network endpoint is acting as the client
>  #
> @@ -126,11 +126,11 @@
>  
>  ##
>  # @QCryptoIVGenAlgo:
> -#
> -# The supported algorithms for generating initialization vectors for
> -# full disk encryption.  The 'plain' generator should not be used for
> -# disks with sector numbers larger than 2^32, except where
> -# compatibility with pre-existing Linux dm-crypt volumes is required.
> +#     The supported algorithms for generating initialization vectors
> +#     for full disk encryption.  The 'plain' generator should not be
> +#     used for disks with sector numbers larger than 2^32, except
> +#     where compatibility with pre-existing Linux dm-crypt volumes is
> +#     required.

'plain' should be @plain, and this part of the text should probably go
below the member descriptions.  I spotted related issues in review of
your "[PATCH 12/12] qapi: convert simple command intros for
block-core.json" and "[PATCH 5/5] qapi: convert simple event intros for
block-core.json".  Same reaction: leave for later, note future work:

1. Add missing markup to argument / member / feature references.

2. Review and improve doc comments where the intro refers to arguments /
members / features.

>  #
>  # @plain: 64-bit sector number truncated to 32-bits
>  #


Reply via email to