On Thu, Sep 10, 2026 at 01:51:25PM +0200, Thomas Huth wrote:
> When building QEMU for NetBSD ("make vm-build-netbsd"), the compiler
> complains:
>
> In file included from /usr/include/ctype.h:100,
> from ../src/include/qemu/osdep.h:123,
> from ../src/hw/ppc/vof.c:12:
> ../src/hw/ppc/vof.c: In function 'path_offset':
> ../src/hw/ppc/vof.c:150:31: warning: array subscript has type 'char'
> [-Wchar-subscripts]
> 150 | *at = tolower(*at);
>
> tolower() should not be used with plain "char" variables since these
> can be signed and tolower() could be implemented as a macro that uses
> its parameter to index into an array. Use our wrapper qemu_tolower()
> to fix this problem.
>
> Signed-off-by: Thomas Huth <[email protected]>
> ---
> hw/ppc/vof.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <[email protected]>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
