Fabiano Rosas <[email protected]> writes:

> The migrate_set_parameter_completion function is the last user of the
> MigrationParameter enum.

Not true, there's still the assertion in
migrate_mark_all_params_present(), and hmp_completion_single() in
tests/qtest/migration/misc-tests.c.

The assertion is unclean: it uses MIGRATION_PARAMETER__MAX for number of
MigrationParameters members, which tacitly assumes MigrationParameter
matches MigrationParameters.

>                          Write the code using an output visitor and
> QDict instead so we can remove the enum in a future patch.
>
> Signed-off-by: Fabiano Rosas <[email protected]>


Reply via email to