gdb_feature_builder_end() never propagated builder->base_reg into feature->base_reg, leaving it at 0 for all dynamically-built features. This made the trace log at gdb_get_register_list() report an incorrect base_reg for dynamic features.
GDBRegisterState::base_reg was correctly set, so this doesn't fix an actual issue. Signed-off-by: Marc-André Lureau <[email protected]> --- gdbstub/gdbstub.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 0ce871d74929..912e31b66744 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -476,6 +476,7 @@ void gdb_feature_builder_end(const GDBFeatureBuilder *builder) g_ptr_array_free(builder->xml, TRUE); + builder->feature->base_reg = builder->base_reg; builder->feature->num_regs = builder->regs->len; builder->feature->regs = (void *)g_ptr_array_free(builder->regs, FALSE); trace_gdbxml_feature_builder_header(builder->feature->name, -- 2.55.0.543.g5ebe2ebe4ea8
