> On Sep 11, 2026, at 03:08, Shameer Kolothum Thodi <[email protected]> > wrote: > >> -----Original Message----- >> From: Matt Ochs <[email protected]> >> Sent: 03 September 2026 19:47 >> To: [email protected] >> Cc: [email protected]; Peter Maydell <[email protected]>; Eric >> Auger <[email protected]>; Nicolin Chen <[email protected]>; >> Shameer Kolothum Thodi <[email protected]>; qemu- >> [email protected] >> Subject: [PATCH] hw/arm/tegra241-cmdqv: Keep VINTF page0 region alive >> >> >> >> memory_region_add_subregion_overlap(&cmdqv->mmio_cmdqv, >> CMDQV_VINTF_PAGE0_BASE, >> - cmdqv->mr_vintf_page0, 1); >> + &cmdqv->mr_vintf_page0, 1); >> + cmdqv->mr_vintf_page0_initialized = true; > > Do we really need the bool mr_vintf_page0_initialized or can use > memory_region_is_mapped() instead? > Since the region stays a subregion while disabled, memory_region_is_mapped() > still returns true, so it should work for the "initialized" check, I think.
Thanks for the review and suggestion. I agree with this cleaner approach and will send a v2 shortly. -matt
