On Fri, Sep 11, 2026 at 8:34 PM Brian Cain <[email protected]> wrote:
> > On 9/11/2026 5:08 PM, Taylor Simpson wrote: > > Currently, we check for register multiwrites during packet decode. The > > downside of this approach is that it only checks a single destination > > register for each instruction. During analyze_packet, we can check > > for more than one write per instruction. Further, we can check for > > different types of registers. This series adds checks for HVX > > v-registers and q-registers. > > > > Note that multiple writes to a predicate register are allowed on Hexagon. > > > > Changes in v2 > > - Rebase against latest sources, including Hexagon system mode > > - Add checks for multiple writes to system registers > > > > Taylor Simpson (10): > > Hexagon (target/hexagon) Move code out of gen_start_packet > > Hexagon (target/hexagon) Check for GPR multiwrite in analyze_packet > > Hexagon (tests/tcg/hexagon) Add tests for multi-destination > > instructions > > Hexagon (target/hexagon) Check for vreg multiwrite in analyze_packet > > Hexagon (tests/tcg/hexagon) Add tests for vreg multiple writes > > Hexagon (target/hexagon) Check for qreg multiwrite in analyze_packet > > Hexagon (tests/tcg/hexagon) Add tests for qreg multiple writes > > Hexagon (target/hexagon) Check for greg multiwrite in analyze_packet > > Hexagon (target/hexagon) Check for sreg multiwrite in analyze_packet > > Hexagon (target/hexagon) Remove old way of detecting register > > multiwrites > > The greg multiwrite change seems to have an issue here. clear_pkt_ctx() > needs to clear gregs_multi_write? > > You can reproduce the test failures locally with `make check-functional`. > Correct. There are problems with both gregs and sregs. I'll make the fixes in V3 Should I add a multi-write test to check-functional? If so, please advise on the easiest way to do this. Thanks, Taylor
