On 26/08/31 07:29AM, Saif Abrar wrote: > From: Saif Abrar <[email protected]> > > <...snip...> > --- /dev/null > +++ b/tests/qtest/pnv-phb-test.c > @@ -0,0 +1,100 @@ > +/* > + * QTest testcase for PowerNV PHB > + * > + * Copyright (c) 2026, IBM Corporation. > + * > + * SPDX-License-Identifier: GPL-2.0-or-later > + * > + */ > + > +#include "qemu/osdep.h" > +#include "libqtest.h" > +#include "hw/pci-host/pnv_phb4_regs.h" > +#include "pnv-xscom.h" > +#include "pnv-qtest-common.h" > + > +#define PHB3_PBCQ_SPCI_ASB_ADDR 0x0 > +#define PHB3_PBCQ_SPCI_ASB_DATA 0x2 > + > +/* Index of PNV_CHIP_POWER10 in pnv_chips[] within "pnv-xscom.h" */
minor nit: seems like a leftover comment from patch #3 please feel free to retain the rb with above removed: Reviewed-by: Aditya Gupta <[email protected]> Thanks, - Aditya G
