On 9/11/2026 11:46 AM, Akihiko Odaki wrote:
On 2026/09/11 23:19, Brian Cain wrote:
The call to virtio_gpu_virgl_resource_new_blob() should be guarded like
s/call to/definition of/
yeah - I was going to send a v2 when I noticed this but realized that
Marc-Andre had sent their fix prior to mine. So I figured this one was
obsolete.
the (sole) caller is, to avoid -Wunused-function.
../hw/display/virtio-gpu-virgl.c:328:1: error:
‘virtio_gpu_virgl_resource_new_blob’ defined but not used
[-Werror=unused-function]
328 | virtio_gpu_virgl_resource_new_blob(uint32_t resource_id,
uint64_t blob_size)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Brian Cain <[email protected]>
May also have:
Fixes: d814b44636d0 ("hw/display/virtio-gpu: introduce
virtio_gpu_{simple,virgl}_resource_new()")
Nevertheless, everything other than these nits looks good, so:
Reviewed-by: Akihiko Odaki <[email protected]>
Regards,
Akihiko Odaki
---
hw/display/virtio-gpu-virgl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/display/virtio-gpu-virgl.c
b/hw/display/virtio-gpu-virgl.c
index 1c9380e2a6d..f45571060fe 100644
--- a/hw/display/virtio-gpu-virgl.c
+++ b/hw/display/virtio-gpu-virgl.c
@@ -324,6 +324,7 @@ virtio_gpu_virgl_resource_new(uint32_t
resource_id, uint32_t width,
return res;
}
+#if VIRGL_VERSION_MAJOR >= 1
static struct virtio_gpu_virgl_resource *
virtio_gpu_virgl_resource_new_blob(uint32_t resource_id, uint64_t
blob_size)
{
@@ -335,6 +336,7 @@ virtio_gpu_virgl_resource_new_blob(uint32_t
resource_id, uint64_t blob_size)
return res;
}
+#endif
static void virgl_cmd_create_resource_2d(VirtIOGPU *g,
struct
virtio_gpu_ctrl_command *cmd)
