On 9/14/2026 12:27 AM, Alex Bennée wrote: > Pierrick Bouvier <[email protected]> writes: > >> On 9/10/26 11:14 AM, Alex Bennée wrote: >>> As the meson tcg build routes the container builds through docker.py >>> we can also clean up its hack which involved appending a RUN line to >>> the dockerfile. All the dockerfiles that care will work with the >>> --build-arg. >>> Signed-off-by: Alex Bennée <[email protected]> >>> --- >>> tests/docker/docker.py | 13 ++++++------- >>> tests/tcg/meson.build | 3 ++- >>> 2 files changed, 8 insertions(+), 8 deletions(-) >>> >> >> I'm not sure why this was added in the first place. >> Technically, running the container with a specific uid (whether or not >> a user is declared for it) is enough. The only errors you can have is >> if some specific commands ran expect to check if user exist on the >> machine, like sudo for instance. >> For our need (cross compilation), it's not needed, as a compiler will >> never check who is $USER. Files written will still have the correct >> uid on host fs anyway. > > That's why you do the mapping. Before I was seeing a whole bunch of the > test files with a random group ownership. >
I was talking about the adduser part in the container themselves. Mapping users with container run -u is needed, but having a matching user is not strictly needed. >> >> Do you have more info on this? >> >> Regards, >> Pierrick >
