On 9/14/26 10:04 PM, Paolo Bonzini wrote:
On 9/15/26 02:27, Pierrick Bouvier wrote:
Recent switch to tcg-tests removed a part of configure that was generating
config .mak files, that were reused in other places of the tree:
- linux-user vdso
- pc-bios
Taking a look closer, our roms sources are supposed to be in roms folder
Says who?
It was not said on an authoritative tone.
I can reformulate to be understood better:
Taking a look closer, it seems to me that our roms sources are mostly
located in roms folder, to the exception of the one in this series,
which are in pc-bios.
You haven't even *tried* to look at the difference between pc-bios/ and
roms/, i.e. that pc-bios/ tries to use the container-based cross
compilers. Because if you had, you would have mentioned it in the
commit message.
I noticed this difference, and mentioned on original thread that I would
not port the cross container part to avoid duplication. Those files are
not built in CI, nor by default, so it was not obvious for me they have
a special status vs the rest of roms/.
NACK.
Without the move to roms/, does the change to Makefiles seem interesting
to you, or do you prefer to keep configure as it was with no change?
Paolo
Regards,
Pierrick
