On 9/15/2026 4:09 AM, Ilya Leoshkevich wrote:
> The meson conversion dropped the SLOF libc include path that commit
> 3fa010d5317 ("tests/tcg/s390x: Use the SLOF libc headers for the
> multiarch tests") had added, breaking the build on systems without a
> cross-libc, such as Fedora.
> 
> Rather than reintroducing a dependency on the SLOF submodule, which no
> other tcg test has, declare the three functions that the reused pc-bios
> code actually needs: memcpy(), memset(), and printf().
> 
> Reported-by: Daniel P. Berrangé <[email protected]>
> Reported-by: Alex Bennée <[email protected]>
> Closes: https://patchew.org/QEMU/[email protected]/
> Suggested-by: Pierrick Bouvier <[email protected]>
> Fixes: cd81cf86834 ("tests/tcg/s390x: system tests")
> Signed-off-by: Ilya Leoshkevich <[email protected]>
> ---
> 
> v1: 
> https://lore.kernel.org/qemu-devel/[email protected]/
> v1 -> v2: Drop the SLOF dependency (Pierrick)
> 
>  tests/tcg/s390x/libc/stdio.h       | 11 +++++++++++
>  tests/tcg/s390x/libc/string.h      | 12 ++++++++++++
>  tests/tcg/s390x/system/meson.build |  2 ++
>  3 files changed, 25 insertions(+)
>  create mode 100644 tests/tcg/s390x/libc/stdio.h
>  create mode 100644 tests/tcg/s390x/libc/string.h
> 

Reviewed-by: Pierrick Bouvier <[email protected]>

Reply via email to