On Tue, Sep 15, 2026 at 6:59 PM Markus Armbruster <[email protected]> wrote: > > Zhang Chen <[email protected]> writes: > > > Now that holder-aware callers have been converted, rename > > iothread_get_aio_context() to iothread_unsafe_get_aio_context() and > > update qmp_x_blockdev_set_iothread(). > > > > The block graph retains only the AioContext, while detachment happens > > outside qmp_x_blockdev_set_iothread(), so this call site cannot provide > > a matching holder lifecycle. The new name makes its existing lifetime > > assumption explicit. > > Suggest something like > > The only remaining user is qmp_x_blockdev_set_iothread(). It cannot > use iothread_ref_and_get_aio_context() as is, because it ties the > AioContext to the block node, and iothread_unref_and_put_aio_context() > would have to be called when that tie is broken.
Looks better~ I'll use your wording in the next revision. > > > New code should use iothread_ref_and_get_aio_context(). > > > > Reviewed-by: Stefan Hajnoczi <[email protected]> > > Signed-off-by: Zhang Chen <[email protected]> > > Reviewed-by: Markus Armbruster <[email protected]> > If you have time, could you also take a look at the remaining patches converting IOThread users to the holder-aware API? I'd appreciate your feedback. Thanks Chen
