John Snow <[email protected]> writes: > Review notes: Only one event; as in the command splitting patch, the > details section is not physically relocated; I will change this if > requested - but as we are not finished review, I prefer to keep it > this way to ensure mechanical ease of separating "changes" from > "motion" as is customary in our lands. > > (Hint: relocating "Since:" and "Details" sections is a colossal amount > of purely mechanical motion, so I recommend we simply deal with it all > at once when we are done agreeing on the splits.)
Future patches. We need to keep the conversion patches focused on just the conversion, or else they become unreviewable. > Signed-off-by: John Snow <[email protected]> > --- > qapi/machine-s390x.json | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/qapi/machine-s390x.json b/qapi/machine-s390x.json > index dcbad9b4039..670a1f9d926 100644 > --- a/qapi/machine-s390x.json > +++ b/qapi/machine-s390x.json > @@ -57,8 +57,7 @@ > > ## > # @CPU_POLARIZATION_CHANGE: > -# > -# Emitted when the guest asks to change the polarization. > +# Emitted when the guest asks to change the polarization. > # > # The guest can tell the host (via the PTF instruction) whether the > # CPUs should be provisioned using horizontal or vertical "Intro" conversion is pretty much the same for commands and events. I'd squash this into the previous patch, and call it "for commands and events". Up to you.
