Signed-off-by: Richard Henderson <[email protected]>
---
include/tcg/tcg-op-common.h | 4 --
include/tcg/tcg-op-def.h.inc | 1 +
tcg/tcg-op.c | 131 ++++++++++++-----------------------
3 files changed, 46 insertions(+), 90 deletions(-)
diff --git a/include/tcg/tcg-op-common.h b/include/tcg/tcg-op-common.h
index b9118a6df08..7973738331a 100644
--- a/include/tcg/tcg-op-common.h
+++ b/include/tcg/tcg-op-common.h
@@ -134,8 +134,6 @@ void tcg_gen_plugin_mem_cb(TCGv_i64 addr, unsigned meminfo);
void tcg_gen_deposit_z_i32(TCGv_i32 ret, TCGv_i32 arg,
unsigned int ofs, unsigned int len);
-void tcg_gen_extract_i32(TCGv_i32 ret, TCGv_i32 arg,
- unsigned int ofs, unsigned int len);
void tcg_gen_sextract_i32(TCGv_i32 ret, TCGv_i32 arg,
unsigned int ofs, unsigned int len);
void tcg_gen_extract2_i32(TCGv_i32 ret, TCGv_i32 al, TCGv_i32 ah,
@@ -183,8 +181,6 @@ void tcg_gen_st_i32(TCGv_i32 arg1, TCGv_ptr arg2,
tcg_target_long offset);
void tcg_gen_deposit_z_i64(TCGv_i64 ret, TCGv_i64 arg,
unsigned int ofs, unsigned int len);
-void tcg_gen_extract_i64(TCGv_i64 ret, TCGv_i64 arg,
- unsigned int ofs, unsigned int len);
void tcg_gen_sextract_i64(TCGv_i64 ret, TCGv_i64 arg,
unsigned int ofs, unsigned int len);
void tcg_gen_extract2_i64(TCGv_i64 ret, TCGv_i64 al, TCGv_i64 ah,
diff --git a/include/tcg/tcg-op-def.h.inc b/include/tcg/tcg-op-def.h.inc
index a2244bedeb2..856338aa0d4 100644
--- a/include/tcg/tcg-op-def.h.inc
+++ b/include/tcg/tcg-op-def.h.inc
@@ -17,6 +17,7 @@ DEF5(deposit, TCGV, TCGV, TCGV, unsigned, unsigned)
DEF1(discard, TCGV)
DEF3(div, TCGV, TCGV, TCGV)
DEF3(divu, TCGV, TCGV, TCGV)
+DEF4(extract, TCGV, TCGV, unsigned, unsigned)
DEF3(eqv, TCGV, TCGV, TCGV)
DEF2(mov, TCGV, TCGV)
DEF2(movi, TCGV, TINT)
diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c
index 7c5f6ae8e6b..ade5d8bf835 100644
--- a/tcg/tcg-op.c
+++ b/tcg/tcg-op.c
@@ -692,6 +692,51 @@ static void gen_eqv(TCGType type, TCGTemp *dst, TCGTemp
*src1, TCGTemp *src2)
}
}
+static void gen_extract(TCGType type, TCGTemp *dst, TCGTemp *src,
+ unsigned int ofs, unsigned int len)
+{
+ unsigned width = tcg_type_size(type) * 8;
+ uint64_t mask;
+
+ tcg_debug_assert(ofs < width);
+ tcg_debug_assert(len > 0);
+ tcg_debug_assert(len <= width);
+ tcg_debug_assert(ofs + len <= width);
+
+ /* Canonicalize certain special cases, even if extract is supported. */
+ if (ofs + len == width) {
+ gen_shri(type, dst, src, ofs);
+ return;
+ }
+
+ if (TCG_TARGET_extract_valid(type, ofs, len)) {
+ gen_op_ttii(INDEX_op_extract, type, dst, src, ofs, len);
+ return;
+ }
+
+ /* Assume that zero-extension, if available, is cheaper than a shift. */
+ if (TCG_TARGET_extract_valid(type, 0, ofs + len)) {
+ gen_op_ttii(INDEX_op_extract, type, dst, src, 0, ofs + len);
+ gen_shri(type, dst, dst, ofs);
+ return;
+ }
+ if (TCG_TARGET_extract_valid(type, 0, len)) {
+ gen_shri(type, dst, src, ofs);
+ gen_op_ttii(INDEX_op_extract, type, dst, dst, 0, len);
+ return;
+ }
+
+ mask = MAKE_64BIT_MASK(0, len);
+ if (tcg_op_imm_match(INDEX_op_and, type, mask)) {
+ gen_shri(type, dst, src, ofs);
+ /* Do not recurse with gen_andi. */
+ gen_and(type, dst, dst, tcg_constant_internal(type, mask));
+ } else {
+ gen_shli(type, dst, src, width - len - ofs);
+ gen_shri(type, dst, dst, width - len);
+ }
+}
+
static void gen_extrh_i64_i32(TCGTemp *dst, TCGTemp *src)
{
gen_op_tt(INDEX_op_extrh_i64_i32, TCG_TYPE_I32, dst, src);
@@ -1067,49 +1112,6 @@ void tcg_gen_deposit_z_i32(TCGv_i32 ret, TCGv_i32 arg,
}
}
-void tcg_gen_extract_i32(TCGv_i32 ret, TCGv_i32 arg,
- unsigned int ofs, unsigned int len)
-{
- uint32_t mask;
-
- tcg_debug_assert(ofs < 32);
- tcg_debug_assert(len > 0);
- tcg_debug_assert(len <= 32);
- tcg_debug_assert(ofs + len <= 32);
-
- /* Canonicalize certain special cases, even if extract is supported. */
- if (ofs + len == 32) {
- tcg_gen_shri_i32(ret, arg, 32 - len);
- return;
- }
-
- if (TCG_TARGET_extract_valid(TCG_TYPE_I32, ofs, len)) {
- tcg_gen_op4ii_i32(INDEX_op_extract, ret, arg, ofs, len);
- return;
- }
-
- mask = (1u << len) - 1;
- if (ofs == 0) {
- tcg_gen_andi_i32(ret, arg, mask);
- return;
- }
-
- /* Assume that zero-extension, if available, is cheaper than a shift. */
- if (TCG_TARGET_extract_valid(TCG_TYPE_I32, 0, ofs + len)) {
- tcg_gen_op4ii_i32(INDEX_op_extract, ret, arg, 0, ofs + len);
- tcg_gen_shri_i32(ret, ret, ofs);
- return;
- }
-
- if (tcg_op_imm_match(INDEX_op_and, TCG_TYPE_I32, mask)) {
- tcg_gen_shri_i32(ret, arg, ofs);
- tcg_gen_andi_i32(ret, ret, mask);
- } else {
- tcg_gen_shli_i32(ret, arg, 32 - len - ofs);
- tcg_gen_shri_i32(ret, ret, 32 - len);
- }
-}
-
void tcg_gen_sextract_i32(TCGv_i32 ret, TCGv_i32 arg,
unsigned int ofs, unsigned int len)
{
@@ -1814,49 +1816,6 @@ void tcg_gen_deposit_z_i64(TCGv_i64 ret, TCGv_i64 arg,
}
}
-void tcg_gen_extract_i64(TCGv_i64 ret, TCGv_i64 arg,
- unsigned int ofs, unsigned int len)
-{
- uint64_t mask;
-
- tcg_debug_assert(ofs < 64);
- tcg_debug_assert(len > 0);
- tcg_debug_assert(len <= 64);
- tcg_debug_assert(ofs + len <= 64);
-
- /* Canonicalize certain special cases, even if extract is supported. */
- if (ofs + len == 64) {
- tcg_gen_shri_i64(ret, arg, 64 - len);
- return;
- }
-
- if (TCG_TARGET_extract_valid(TCG_TYPE_I64, ofs, len)) {
- tcg_gen_op4ii_i64(INDEX_op_extract, ret, arg, ofs, len);
- return;
- }
-
- mask = (1ull << len) - 1;
- if (ofs == 0) {
- tcg_gen_andi_i64(ret, arg, mask);
- return;
- }
-
- /* Assume that zero-extension, if available, is cheaper than a shift. */
- if (TCG_TARGET_extract_valid(TCG_TYPE_I64, 0, ofs + len)) {
- tcg_gen_op4ii_i64(INDEX_op_extract, ret, arg, 0, ofs + len);
- tcg_gen_shri_i64(ret, ret, ofs);
- return;
- }
-
- if (tcg_op_imm_match(INDEX_op_and, TCG_TYPE_I64, mask)) {
- tcg_gen_shri_i64(ret, arg, ofs);
- tcg_gen_andi_i64(ret, ret, mask);
- } else {
- tcg_gen_shli_i64(ret, arg, 64 - len - ofs);
- tcg_gen_shri_i64(ret, ret, 64 - len);
- }
-}
-
void tcg_gen_sextract_i64(TCGv_i64 ret, TCGv_i64 arg,
unsigned int ofs, unsigned int len)
{
--
2.53.0
