Hi Nikhil,
Thanks for reviewing,
On 17/09/26 1:50 PM, Nikhil Kumar Singh wrote:
On 01/09/26 23:11, Narayana Murty N wrote:
+ if (ioctl(container->fd, VFIO_EEH_PE_OP, &op) < 0) {
+ error_report("vfio/eeh errinjct: VFIO_EEH_PE_OP failed: %s",
+ strerror(errno));
+ switch (errno) {
+ case EINVAL:
+ return RTAS_OUT_PARAM_ERROR;
+ case ENOTTY:
+ case EOPNOTSUPP:
+ return RTAS_OUT_NOT_SUPPORTED;
+ default:
+ return RTAS_OUT_HW_ERROR;
+ }
+ }
Hi Narayana,
In existing QEMU EEH code, I have seen that EEH operations call
vfio_eeh_container_ok(container) before EEH ioctl is issued. That part
is missing in this code. Can you please add it? And if that check is
intentionally skipped and not necessary here, could you clarify the
reasoning?
It got removed unintentionally the block
/* Enforce exactly one group per container check matching other EEH
ops */
if (!vfio_eeh_container_ok(container)) {
error_report("vfio/eeh errinjct: kernel requires a container
with exactly one group");
return RTAS_OUT_HW_ERROR;
}
will correct it in next version.
Thanks,
Narayana Murty N
The rest of the patch looks fine to me. Once this concern is addressed,
feel free to add my tag:
Reviewed-by: Nikhil Kumar Singh <[email protected]>
Thanks & Regards
~ Nikhil
