For ZBC/ZAC devices the write granularity is the physical block size, so
a 512e SMR disk exposed through a host_device backend has a logical block
size of 512 and a zone write granularity of 4096. We told the guest
driver 512 while raw_co_zone_append() rejects anything that is not 4096
byte aligned, so the driver saw a plain I/O error for a request it had
been told was valid.
Report the larger of the logical and the physical block size instead.
Both are properties of the device model, so the value that a guest is
given does not change when it is migrated to a host whose disks differ,
which a value taken from BlockLimits would. It is also what a guest
derives for itself: blk_validate_zoned_limits() raises
zone_write_granularity to the logical block size, and for a SCSI disk
sd_zbc_read_zones() takes it from the physical block size.
blkconf_blocksizes() rejects a logical block size larger than the
physical block size, so this is the physical block size in practice. It
is expressed as the larger of the two because that is the constraint
which applies: a guest cannot issue a write finer than the logical block
size, and the medium cannot take one finer than the physical block size.
Add it as a helper next to blkconf_blocksizes(), since it is derived from
a BlockConf, and use it for the zone append offset check in
check_zoned_request(), which validated against bs->bl.write_granularity.
The value reported to the driver and the value that requests are
validated against then cannot drift apart. The helper cannot return zero
because blkconf_blocksizes() always leaves a logical block size behind,
so the check no longer needs to guard against an unset granularity.
Fixes: 4f7366506a96 ("virtio-blk: add zoned storage emulation for zoned
devices")
Signed-off-by: Niklas Cassel <[email protected]>
---
hw/block/block.c | 5 +++++
hw/block/virtio-blk.c | 13 +++++++------
include/block/block_int-common.h | 7 +++++++
include/hw/block/block.h | 13 +++++++++++++
4 files changed, 32 insertions(+), 6 deletions(-)
diff --git a/hw/block/block.c b/hw/block/block.c
index f187fa025d..79b0a67cea 100644
--- a/hw/block/block.c
+++ b/hw/block/block.c
@@ -201,6 +201,11 @@ bool blkconf_blocksizes(BlockConf *conf, Error **errp)
return true;
}
+uint32_t blkconf_zone_write_granularity(BlockConf *conf)
+{
+ return MAX(conf->logical_block_size, conf->physical_block_size);
+}
+
bool blkconf_apply_backend_options(BlockConf *conf, bool readonly,
bool resizable, Error **errp)
{
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index dd69d81532..6bf1049aea 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -516,11 +516,11 @@ static bool check_zoned_request(VirtIOBlock *s, int64_t
offset, int64_t len,
}
if (append) {
- if (bs->bl.write_granularity) {
- if ((offset % bs->bl.write_granularity) != 0) {
- *status = VIRTIO_BLK_S_ZONE_UNALIGNED_WP;
- return false;
- }
+ uint32_t wg_mask = blkconf_zone_write_granularity(&s->conf.conf) - 1;
+
+ if (offset & wg_mask) {
+ *status = VIRTIO_BLK_S_ZONE_UNALIGNED_WP;
+ return false;
}
index = bdrv_zone_index(bs, offset);
@@ -1276,7 +1276,8 @@ static void virtio_blk_update_config(VirtIODevice *vdev,
uint8_t *config)
bs->bl.max_active_zones);
virtio_stl_p(vdev, &blkcfg.zoned.max_open_zones,
bs->bl.max_open_zones);
- virtio_stl_p(vdev, &blkcfg.zoned.write_granularity, blk_size);
+ virtio_stl_p(vdev, &blkcfg.zoned.write_granularity,
+ blkconf_zone_write_granularity(conf));
virtio_stl_p(vdev, &blkcfg.zoned.max_append_sectors,
bs->bl.max_append_sectors);
} else {
diff --git a/include/block/block_int-common.h b/include/block/block_int-common.h
index 82aa0c1a6e..7abd2b12bb 100644
--- a/include/block/block_int-common.h
+++ b/include/block/block_int-common.h
@@ -922,6 +922,13 @@ typedef struct BlockLimits {
/* maximum number of active zones */
uint32_t max_active_zones;
+ /*
+ * The granularity that the backend requires of a write to a sequential
+ * zone, in bytes, or zero if it has none. This describes the host, so it
+ * must not be reported to a guest: a frontend reports
+ * blkconf_zone_write_granularity() and checks this against it when the
+ * device is realized.
+ */
uint32_t write_granularity;
} BlockLimits;
diff --git a/include/hw/block/block.h b/include/hw/block/block.h
index df941df19f..c769b1297d 100644
--- a/include/hw/block/block.h
+++ b/include/hw/block/block.h
@@ -114,6 +114,19 @@ bool blkconf_geometry(BlockConf *conf, int *trans,
unsigned cyls_max, unsigned heads_max, unsigned secs_max,
Error **errp);
bool blkconf_blocksizes(BlockConf *conf, Error **errp);
+/*
+ * The alignment constraint that applies to writes to a sequential zone. A
guest
+ * cannot issue a write finer than the logical block size, and the medium
cannot
+ * take one finer than the physical block size, so the constraint that applies
+ * is the larger of the two. A frontend must report this value to its guest and
+ * validate requests against it.
+ *
+ * It is derived from the configuration and not from the backend, so that a
+ * guest is not given a property of the host, which would differ after
+ * migration. blkconf_blocksizes() rejects a logical block size larger than the
+ * physical block size, so this is the physical block size in practice.
+ */
+uint32_t blkconf_zone_write_granularity(BlockConf *conf);
bool blkconf_apply_backend_options(BlockConf *conf, bool readonly,
bool resizable, Error **errp);
--
2.55.0
