On 9/11/26 4:18 AM, Vladimir Sementsov-Ogievskiy wrote: > On 08. 09. 26 10: 28, Akihiko Odaki wrote: > On 2026/09/05 5: 57, Vladimir > Sementsov-Ogievskiy wrote: >> The action variables are now used only within > system/runstate. c. >> Move them and qmp_set_action() there, make the > variables > > On 08.09.26 10:28, Akihiko Odaki wrote: >> On 2026/09/05 5:57, Vladimir Sementsov-Ogievskiy wrote: >>> The action variables are now used only within system/runstate.c. >>> Move them and qmp_set_action() there, make the variables static, >>> and remove runstate-action.c and its header. >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]> >>> --- >>> MAINTAINERS | 1 - >>> include/system/runstate-action.h | 19 ------------- >>> monitor/qmp-cmds.c | 1 - >>> system/meson.build | 1 - >>> system/runstate-action.c | 46 -------------------------------- >>> system/runstate.c | 34 ++++++++++++++++++++++- >>> system/vl.c | 2 +- >>> ui/cocoa.m | 1 - >>> ui/sdl2.c | 1 - >>> 9 files changed, 34 insertions(+), 72 deletions(-) >>> delete mode 100644 include/system/runstate-action.h >>> delete mode 100644 system/runstate-action.c >>> [...] >>> -} >>> diff --git a/system/runstate.c b/system/runstate.c >>> index 5d10ff0df99..a5f16da975e 100644 >>> --- a/system/runstate.c >>> +++ b/system/runstate.c >>> @@ -2,6 +2,7 @@ >>> * QEMU main system emulation loop >>> * >>> * Copyright (c) 2003-2020 QEMU contributors >>> + * Copyright (c) 2020 Oracle and/or its affiliates. >> >> The deleted runstate-action.c explicitly licensed qmp_set_action() under >> GPLv2. The move retains only Oracle’s copyright line under the destination’s >> MIT header. I guess noting that this file is licensed under GPLv2 is the >> right thing to do here. > > > Hmm.. Funny thing. > > To move qmp_set_action() we need an ack from Oracle. Alejandro could you ack > it? > Hi Vladimir, I don't have any objections to the refactoring itself, but I don't have the authority to act on Oracle's behalf to approve a change in licensing terms from GPLv2 to MIT. I have reached out to the appropriate contacts and I am waiting for their response. Just wanted to let yo know that I am following up on your request, and will reply as soon as I hear back. Alejandro > To move the whole system/runstate.c into GPLv2, we need and ack from > "Copyright (c) 2003-2020 QEMU contributors", which is a lot more difficult. > > To be honest, I don't believe, that qmp_set_action() worth worrying. It's a > small simple function. I think, we often move functions from one license to > another, and don't even look at them. This patch is noticeable because it > removes the whole file, and license is visible in the diff. > > Any opinions? > > -- > Best regards, > Vladimir >
