> +static bool s390_bios_has_string(const char *needle)
> +{
> + const char *contents;
> + gsize len;
> + bool found;
> +
> + contents = s390_bios_load(&len);
> + found = memmem(contents, len, needle, strlen(needle)) != NULL;
> +
> + g_test_message("%s %s", needle, found ? "found" : "not found");
> + return found;
Please see Josh's comment about this
# Setup failed for virtio-net-pci found
leading to a successful test run really confused me.
Basically: re-word it so that it works better with the next patch.
> +}
> +
> +static bool s390_bios_has_net_ccw(void)
> +{
> + /*
> + * virtio-net-ccw has always been supported;
> + * probe for the string it always emits
> + */
... Except for the point in time before 3e4415a751 where the support
was added :D
Yes, we expect it's just always there now, but... If there's nothing
else we can test to verify its presence (preferred) can we at least drop
the comment and just say we are assuming it is present?
