On Fri, Sep 18, 2026 at 07:29:53PM -0300, Fabiano Rosas wrote:
> When calling opts_parse(), there is no need to pass in &help_wanted
> only to call qemu_opts_print_help() in case it's true. The opts_parse
> function itself can call qemu_opts_print_help() and avoid the
> roundtrip.
> 
> qemu_opts_print_help() takes a QemuOptsList pointer. opts_parse() can
> access the list via opts->list.
> 
> Note that this change doesn't avoid the need for opts_parse() to pass
> a pointer into get_opt_name_value().
> 
> Signed-off-by: Fabiano Rosas <[email protected]>
> ---
>  util/qemu-option.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)

Reviewed-by: Daniel P. Berrangé <[email protected]>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|


Reply via email to