Re: [PATCH v5 010/101] tcg: Generic expansion of tcg_gen_movi_*

[Philippe Mathieu-Daudé]

On 27/9/26 10:58, Richard Henderson wrote:

Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
---
  include/tcg/tcg-op-common.h  |  2 --
  include/tcg/tcg-op-def.h.inc |  1 +
  tcg/tcg-op.c                 | 15 +++++----------
  3 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c
index 77ed34fcb8f..b2fa509cd1f 100644
--- a/tcg/tcg-op.c
+++ b/tcg/tcg-op.c
@@ -370,6 +370,11 @@ void tcg_gen_mov(TCGType type, TCGTemp *dst, TCGTemp *src)
      }
  }

+void tcg_gen_movi(TCGType type, TCGTemp *dst, int64_t src)

Maybe this commit (the first converting opcode with an integer arg)
could have a description explaining / reminding now all args are
passed as int64_t.

+{
+    tcg_gen_op_tt(INDEX_op_mov, type, dst, tcg_constant_internal(type, src));
+}
+
  /* 32 bit ops */

void tcg_gen_discard_i32(TCGv_i32 arg)

@@ -377,11 +382,6 @@ void tcg_gen_discard_i32(TCGv_i32 arg)
      tcg_gen_op1_i32(INDEX_op_discard, TCG_TYPE_I32, arg);
  }

-void tcg_gen_movi_i32(TCGv_i32 ret, int32_t arg)

-{
-    tcg_gen_mov_i32(ret, tcg_constant_i32(arg));
-}