On Wed, Sep 23, 2026 at 07:11:11PM +0200, Philippe Mathieu-Daudé wrote: > Date: Wed, 23 Sep 2026 19:11:11 +0200 > From: Philippe Mathieu-Daudé <[email protected]> > Subject: [PATCH v3 17/21] target/i386: Use an acquire load for > interrupt_request > X-Mailer: git-send-email 2.53.0 > > x86_cpu_has_work() may run without the BQL, but currently reads > CPUState::interrupt_request directly. Other threads update this > field with qatomic_or() in cpu_set_interrupt(), so the direct > read races with an atomic access. > > Load the interrupt request with qatomic_load_acquire(), matching > cpu_test_interrupt(). This provides the acquire ordering required > before x86_cpu_pending_interrupt() inspects the CPU state. > > Suggested-by: Paolo Bonzini <[email protected]> > Signed-off-by: Philippe Mathieu-Daudé <[email protected]> > --- > target/i386/cpu.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Zhao Liu <[email protected]> (and I agree with Richard's comment :-)) Regards, Zhao
