On 07/24/2012 05:04 AM, Paolo Bonzini wrote: > There is really no change in the behavior of the job here, since there > is still a maximum of one in-flight I/O operation between the source and > the target. However, this patch already introduces moves the copy logic
grammar: 'already introduces moves' is awkward, but I'm not sure what you meant. > from mirror_iteration to AIO callbacks; it also adds the logic to count > in-flight operations, and only complete the job after they have finished. s/complete/completes/ > > Some care is required in the error and cancellation cases, in order > to avoid access to dangling pointers (and consequent corruption). > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > block/mirror.c | 161 > ++++++++++++++++++++++++++++++++++++++++++-------------- > trace-events | 2 + > 2 files changed, 123 insertions(+), 40 deletions(-) > > diff --git a/block/mirror.c b/block/mirror.c > index 81a600b..971c923 100644 > --- a/block/mirror.c > +++ b/block/mirror.c > @@ -17,7 +17,7 @@ > #include "qemu/ratelimit.h" > #include "bitmap.h" > > -#define SLICE_TIME 100000000ULL /* ns */ > +#define SLICE_TIME 100000000ULL /* ns */ Why the spurious respacing? -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature