On 2026/9/28 下午4:26, SignKirigami wrote:
Now csr helpers are set by SET_CSR_FUNC in trans_privileged.c.inc, so this
macro is unneeded.
Signed-off-by: SignKirigami <[email protected]>
---
target/loongarch/csr.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/target/loongarch/csr.c b/target/loongarch/csr.c
index d2ac39dee9..e4ad8a4618 100644
--- a/target/loongarch/csr.c
+++ b/target/loongarch/csr.c
@@ -6,21 +6,20 @@
#include "cpu.h"
#include "csr.h"
-#define CSR_OFF_FUNCS(NAME, FL, RD, WR) \
- [LOONGARCH_CSR_##NAME] = { \
- .name = (stringify(NAME)), \
- .offset = CSR_OFFSET(CSR_##NAME), \
- .flags = FL, .readfn = RD, .writefn = WR \
+#define CSR_OFF_FLAGS(NAME, FL) \
+ [LOONGARCH_CSR_##NAME] = { \
+ .name = (stringify(NAME)), \
+ .offset = CSR_OFFSET(CSR_##NAME), \
+ .flags = FL, .readfn = NULL, .writefn = NULL \
I think ".readfn = NULL, .writefn = NULL" can be removed, since csr_info
array is defined as static variable.
}
#define CSR_OFF_ARRAY(NAME, N) \
[LOONGARCH_CSR_##NAME(N)] = { \
.name = (stringify(NAME##N)), \
.offset = CSR_OFFSET(CSR_##NAME[N]), \
- .flags = CSRFL_BASIC, .readfn = NULL, .writefn = NULL \
+ .flags = CSRFL_BASIC, .readfn = NULL, .writefn = NULL \
Ditto.
".readfn = NULL, .writefn = NULL" can be removed here.
Regards
Bibo Mao
}
-#define CSR_OFF_FLAGS(NAME, FL) CSR_OFF_FUNCS(NAME, FL, NULL, NULL)
#define CSR_OFF(NAME) CSR_OFF_FLAGS(NAME, CSRFL_BASIC)
static CSRInfo csr_info[] = {
