Re: [RFC PATCH v4 22/25] target/arm/kvm: add kvm_arm_get_host_isar helper

[Philippe Mathieu-Daudé]

On 21/9/26 14:32, Khushit Shah wrote:

Introduce kvm_arm_get_host_isar() to provide the host ISAR probed through
a scratch vCPU. It will be needed by later commits.

Signed-off-by: Khushit Shah <khushit.s...@nutanix.com>
---
  target/arm/kvm-stub.c | 5 +++++
  target/arm/kvm.c      | 8 ++++++++
  target/arm/kvm_arm.h  | 4 ++++
  3 files changed, 17 insertions(+)

diff --git a/target/arm/kvm-stub.c b/target/arm/kvm-stub.c
index c9cd47bf47..059a7afdcb 100644
--- a/target/arm/kvm-stub.c
+++ b/target/arm/kvm-stub.c
@@ -151,3 +151,8 @@ void kvm_arm_field_get_supported_values(const 
ARM64SysRegField *field,
  {
      g_assert_not_reached();
  }
+
+const ARMISARegisters *kvm_arm_get_host_isar(void)
+{
+    return NULL;
+}

This stub could be avoided if using in qmp_query_cpu_props_info():

  if (kvm_enabled()) {
      host_isar = kvm_arm_get_host_isar();
  } else {
      error_setg(errp, "query-cpu-props-info requires KVM");
      return NULL;
  }