John Snow <[email protected]> writes: > This patch finalizes the total ordering of all QAPI documentation > block sections. > > ... Except TODO, which can still be wherever. > > Signed-off-by: John Snow <[email protected]> > --- > scripts/qapi/parser.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py > index 8b331aa0673..c14bff2cbc3 100644 > --- a/scripts/qapi/parser.py > +++ b/scripts/qapi/parser.py > @@ -552,7 +552,7 @@ def _tag_check(this: Union['QAPIDoc.Kind', str]) -> None: > if isinstance(this, str): > this = QAPIDoc.Kind.from_string(this) > > - if this in (QAPIDoc.Kind.TODO, QAPIDoc.Kind.SINCE): > + if this == QAPIDoc.Kind.TODO: > return > > if this.value < last_ordered_section.value:
The check for duplicate RETURNS, ERRORS, SINCE in new_tagged_section() is now technically redundant. Deleting it would make the error message worse, though. Do we care?
