On 10/2/2026 7:28 AM, Alistair Francis wrote:
On Thu, 2026-10-01 at 10:22 +0800, Tao Ding wrote:
Cast slot to hwaddr before multiplication to prevent 32-bit overflow
when
calculating the SRAM input address.
Resolves: Coverity CID 1685514
Reported-by: Alistair Francis<[email protected]>
Signed-off-by: Tao Ding<[email protected]>
---
tests/qtest/k230-decomp-gzip-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/k230-decomp-gzip-test.c b/tests/qtest/k230-
decomp-gzip-test.c
index e80113fd28..249c8ae82c 100644
--- a/tests/qtest/k230-decomp-gzip-test.c
+++ b/tests/qtest/k230-decomp-gzip-test.c
@@ -46,7 +46,7 @@ static inline hwaddr k230_sram_addr(hwaddr off)
static inline hwaddr k230_sram_input_addr(unsigned int slot)
{
return k230_sram_addr(K230_DECOMP_GZIP_SRAM_IN_BASE +
- slot * K230_DECOMP_GZIP_BLOCK_SIZE);
+ (hwaddr) slot *
K230_DECOMP_GZIP_BLOCK_SIZE);
What is the point of this function? It's only ever passed 0
The hardware has two input SRAM slots (|K230_DECOMP_GZIP_INPUT_SLOTS| is 2).
This helper is intended to calculate the address for either slot.
The current test only uses slot 0 because its input in a single block.
Alistair
}
/*
