On Sun, Oct 4, 2026 at 8:36 PM Bernhard Beschow <[email protected]> wrote:
>
> Using sysbus_realize_and_unref() requires object_new() rather than
> object_new_with_props(), otherwise the initial reference count is
> subtracted twice, i.e. ends up being one too low.
>
> board")
corrupted commit message?
>
> Fixes: 7bcd1f30bc83 ("hw/arm: Add the i.MX 8MM EVK(Evaluation Kit)
> cc: qemu-stable
> Reported-by: Peter Maydell <[email protected]>
> Reviewed-by: Peter Maydell <[email protected]>
> Signed-off-by: Bernhard Beschow <[email protected]>
> ---
> hw/arm/imx8mm-evk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm/imx8mm-evk.c b/hw/arm/imx8mm-evk.c
> index c3215b11cb..6de0d9c4a2 100644
> --- a/hw/arm/imx8mm-evk.c
> +++ b/hw/arm/imx8mm-evk.c
> @@ -83,8 +83,8 @@ static void imx8mm_evk_init(MachineState *machine)
> ims->bootinfo.psci_conduit = QEMU_PSCI_CONDUIT_SMC;
> ims->bootinfo.modify_dtb = imx8mm_evk_modify_dtb;
>
> - s = FSL_IMX8MM(object_new_with_props(TYPE_FSL_IMX8MM, OBJECT(machine),
> - "soc", &error_fatal, NULL));
> + s = FSL_IMX8MM(object_new(TYPE_FSL_IMX8MM));
> + object_property_add_child(OBJECT(machine), "soc", OBJECT(s));
> object_property_set_uint(OBJECT(s), "fec1-phy-num", 1, &error_fatal);
> sysbus_realize_and_unref(SYS_BUS_DEVICE(s), &error_fatal);
>
Otherwise,
Reviewed-by: Bin Meng <[email protected]>
