Hi On Mon, Oct 5, 2026 at 1:29 PM Peter Maydell <[email protected]> wrote: > > On Sun, 4 Oct 2026 at 11:26, Marc-André Lureau > <[email protected]> wrote: > > > > Voice ranges up to 31 (NumVoices & 31), so 1 << 31 is undefined > > behavior in C as it shifts into the sign bit of a signed int. > > Use 1U to make the shift well-defined. > > > This is *not* undefined behaviour for QEMU, because we use > -fwrapv specifically to avoid it being UB. The change is > reasonable enough, but we wouldn't be doing it for UB reasons.
Right, I'll adjust the commit message. And also update gusemu_hal.c for similar correctness fix thanks
