On 07/30/2012 01:12 PM, Juan Quintela wrote: > Orit Wasserman <owass...@redhat.com> wrote: >> The management can enable/disable a capability for the next migration by >> using >> migrate_set_parameter command. >> The management can query the current migration capabilities using >> query-migrate-parameters >> >> Signed-off-by: Orit Wasserman <owass...@redhat.com> >> Signed-off-by: Juan Quintela <quint...@redhat.com> > > I just noticed .... shouldn't we use > > migrate_set_parameter cache_size 256M > ??? > > I think that even the old migration parameters could be added to this > one? > > migrate_set_parameter downtime 30ms > migrate_set_parameter bandwidth 1G
The existing patch was written under the assumption that parameters were only ever bool; but you are proposing allowing non-bool parameters. > > This way everything would be more regular, and easier on libvirt, as new > parameters would be trivial to ask for? That depends on the QMP interface you come up with for expressing non-bool parameters. This patch series has already been churning for several months now, which makes it feel a bit late to be changing the interface to support non-bool parameters, unless we really like the idea and can afford another delay in getting this series in. -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
