Hi John! Cc'ing Ani / Luigi & Mark.
On 2026-10-07 20:35, John Snow wrote:
Currently, these functions are located in kvm-common.c. However, when configuring QEMU with `--without-default-devices`, we encounter a linking error at final assembly time where these functions cannot be located. As a quick hack, I've moved the functions into kvm.c to allow defaultless-compilations of x86_64 to succeed. This may not be the correct or most elegant approach, but it does restore a compilation feature that was working in v10.0.0 and broken by v11.0.0. Suggestions? Suggested-by: Paolo Bonzini <[email protected]> Signed-off-by: John Snow <[email protected]> --- hw/i386/x86-common.c | 125 ----------------------------------------- hw/i386/x86.c | 130 ++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 129 insertions(+), 126 deletions(-)
Can we move to a new hw/i386/x86-bios.c file instead? Otherwise: Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
