Re: [PATCH v2] target/loongarch: delete CSR_OFF_FUNCS

[Bibo Mao]

On 2026/10/8 上午11:10, SignKirigami wrote:

Now csr helpers are set by SET_CSR_FUNC in trans_privileged.c.inc, so this
macro is unneeded.

Signed-off-by: SignKirigami <prc...@krgm.moe>
---
  target/loongarch/csr.c | 15 +++++++--------
  1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/target/loongarch/csr.c b/target/loongarch/csr.c
index d2ac39dee9..e474941337 100644
--- a/target/loongarch/csr.c
+++ b/target/loongarch/csr.c
@@ -6,21 +6,20 @@
  #include "cpu.h"
  #include "csr.h"

-#define CSR_OFF_FUNCS(NAME, FL, RD, WR) \

+#define CSR_OFF_FLAGS(NAME, FL)                            \
      [LOONGARCH_CSR_##NAME] = {                             \
          .name   = (stringify(NAME)),                       \
          .offset = CSR_OFFSET(CSR_##NAME),                  \
-        .flags = FL, .readfn = RD, .writefn = WR           \
+        .flags  = FL                                       \
      }

-#define CSR_OFF_ARRAY(NAME, N) \

-    [LOONGARCH_CSR_##NAME(N)] = {                             \
-        .name   = (stringify(NAME##N)),                       \
-        .offset = CSR_OFFSET(CSR_##NAME[N]),                  \
-        .flags = CSRFL_BASIC, .readfn = NULL, .writefn = NULL           \
+#define CSR_OFF_ARRAY(NAME, N)                             \
+    [LOONGARCH_CSR_##NAME(N)] = {                          \
+        .name   = (stringify(NAME##N)),                    \
+        .offset = CSR_OFFSET(CSR_##NAME[N]),               \
+        .flags  = CSRFL_BASIC                              \
      }

-#define CSR_OFF_FLAGS(NAME, FL) CSR_OFF_FUNCS(NAME, FL, NULL, NULL)

  #define CSR_OFF(NAME)             CSR_OFF_FLAGS(NAME, CSRFL_BASIC)

static CSRInfo csr_info[] = {

Reviewed-by: Bibo Mao <maob...@loongson.cn>