On 10/8/26 02:52, Jamin Lin wrote:
Hi Cédric
Subject: Re: [PATCH v2 0/2] hw/arm/aspeed: Sort device IDs and add IO
expander test
On 10/5/26 04:04, Jamin Lin wrote:
This series is split out from "[PATCH v1 0/11] hw/arm/aspeed: Use
unimp array and table for unimplemented devices" to make the changes
easier to review.
v1
1. sorts the ASPEED device IDs alphabetically.
This is already applied to aspeed-next along with :
https://lore.kernel.org/qemu-devel/20260930072501.2612119-1-jamin_lin@as
peedtech.com/
Please apply the v2 patch instead.
done.
C.
The v1 version breaks the AST2700 IO Expander 1 functionality. This is also why
I added a functional test in v2 to catch this issue.
As a result, the functional test currently fails on aspeed-next with the v1
patch applied.
The v1 change is:
ASPEED_DEV_IOEXP0_I2C,
ASPEED_DEV_IOEXP0_I3C,
ASPEED_DEV_IOEXP0_INTCIO,
ASPEED_DEV_IOEXP1_I2C,
ASPEED_DEV_IOEXP1_I3C,
ASPEED_DEV_IOEXP1_INTCIO,
The correct ordering in v2 is:
https://patchwork.kernel.org/project/qemu-devel/patch/[email protected]/
+ ASPEED_DEV_IOEXP0_I2C,
+ ASPEED_DEV_IOEXP1_I2C,
+ ASPEED_DEV_IOEXP0_I3C,
+ ASPEED_DEV_IOEXP1_I3C,
+ ASPEED_DEV_IOEXP0_INTCIO,
+ ASPEED_DEV_IOEXP1_INTCIO,
Thanks for your help and support.
Jamin
v2
1. Split the device ID sorting change out into a separate series.
2. Fix the IO expander device IDs in the correct order.
3. Add a functional test for IO Expander 1 I2C.
Applied patch 2 to :
https://github.com/legoater/qemu aspeed-next
Thanks,
C.
Jamin Lin (2):
hw/arm/aspeed: Sort device IDs alphabetically
tests/functional/aarch64/test_aspeed_ast2700a2: Add I2C test for IO
expander 1
include/hw/arm/aspeed_soc.h | 176
+++++++++---------
.../aarch64/test_aspeed_ast2700a2.py | 3 +
2 files changed, 91 insertions(+), 88 deletions(-)
