On 10/9/26 4:41 PM, Matthew Rosato wrote:
On 10/9/26 2:55 PM, Collin Walling wrote:There are certain CPU model features that depend on other features that are flagged for deprecation. For example `ineff_nc_tx` depends on the `te` deprecated feature. If a user defines a VM with the current list of deprecated features disabled, the following warning occurs: warning: 'ineff_nc_tx' requires 'te' To alleviate this, add these "dependent features" to the deprecated features list. This allows the user to see *all* features that should be disabled to ensure a successful migration to a host system that may not support certain deprecated features. Fixes: 6e55b32d45 ("target/s390x: flag te and cte as deprecated") Signed-off-by: Collin Walling <[email protected]> Reviewed-by: Hendrik Brueckner <[email protected]>Reviewed-by: Matthew Rosato <[email protected]> I tested to verify that the facility in question (ineff_nc_tx) is not visible to the guest with this patch using host model. I also tested that purposely deprecating S390_FEAT_VECTOR_ENH via the feats[] array correctly picked up both ENH2 and ENH3 via the code added by this patch.
Like you, I have also been messing around with some of the chained features to ensure this behaves as described. Not that they will be deprecated anytime soon, but that the cascading works correctly.
Tested-by: Eric Farman <[email protected]>
Thanks, Matt
