On Tue, Jul 31, 2012 at 12:41 PM, Laszlo Ersek <ler...@redhat.com> wrote: > (in reply to > <http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg02637.html> -- > In-Reply-To set, but that may not be enough for the web archive) > > Looks good to me. A minor nit: 2/2 keeps the close(s->fd) call (instead > of calling closesocket(s->fd), like in eoc handling) in > net_socket_cleanup().
The reason I didn't change close(2) to closesocket() is because -netdev socket,fd= can pass arbitrary file descriptors. I suspect only real socket objects will work but we basically don't know what the passed file descriptor is. This is the reason why I didn't feel 100% happy converting it to closesocket(). > Reviewed-by: Laszlo Ersek <ler...@redhat.com> Thanks! Stefan
