On Tue, Oct 13, 2026 at 11:11:15AM +0100, Alex Bennée wrote: > Daniel P. Berrangé <[email protected]> writes: > > > On Tue, Oct 13, 2026 at 10:35:45AM +0100, Alex Bennée wrote: > >> Daniel P. Berrangé <[email protected]> writes: > >> > >> > On Mon, Oct 12, 2026 at 06:03:20PM +0100, Alex Bennée wrote: > >> >> We now split the fetching of the buildroot image from the kernel > >> >> itself. This is because we will want to access additional metadata in > >> >> future tests. > >> > > >> > This commit message appears unrelated to the patch content or subject > >> > line. > >> > >> The kernel is now coming from: https://storage.tuxboot.com/kernels/6.18.54/ > >> instead of part of the buildroot build in > >> https://storage.tuxboot.com/buildroot/20260924/x86_64/ > > > > Ah ok, I misunderstood what the commit message was trying to say, > > though I'm still underclear how the before/after bzImage differ > > from each other ? > > > > Is the https://storage.tuxboot.com/kernels/6.18.54/ the > > authoritative input for the process that produces > > https://storage.tuxboot.com/buildroot/20260924/x86_64/ ? > > No - they are different builds, but the kernel builds have had the > symbol generation turned on and the buildroot images are generic anyway > which is why they still work together.
Ok, anyway, no objection to the patch. Just expand on the commit message little in any way you feel is useful. No need for me to re-review it. > > > > > I see the later patch is pulling in vmlinuz.xz from the > > former location, so I guess you're trying to just use > > the common location for both kernel images ? > > > >> > >> > > >> >> > >> >> Reviewed-by: Marc-André Lureau <[email protected]> > >> >> Message-ID: <[email protected]> > >> >> Signed-off-by: Alex Bennée <[email protected]> > >> >> --- > >> >> tests/functional/x86_64/test_tuxrun.py | 8 ++++---- > >> >> 1 file changed, 4 insertions(+), 4 deletions(-) > >> >> > >> >> diff --git a/tests/functional/x86_64/test_tuxrun.py > >> >> b/tests/functional/x86_64/test_tuxrun.py > >> >> index 729f6447d05..026b373accb 100755 > >> >> --- a/tests/functional/x86_64/test_tuxrun.py > >> >> +++ b/tests/functional/x86_64/test_tuxrun.py > >> >> @@ -17,11 +17,11 @@ > >> >> class TuxRunX86Test(TuxRunBaselineTest): > >> >> > >> >> ASSET_X86_64_KERNEL = Asset( > >> >> - > >> >> 'https://storage.tuxboot.com/buildroot/20241119/x86_64/bzImage', > >> >> - > >> >> 'f57bfc6553bcd6e0a54aab86095bf642b33b5571d14e3af1731b18c87ed5aef8') > >> >> + 'https://storage.tuxboot.com/kernels/6.18.54/x86_64/bzImage', > >> >> + > >> >> '24a3ade610c2cc426ff821050de8a35930b0371357d94cc2c334abac6658552b') > >> >> ASSET_X86_64_ROOTFS = Asset( > >> >> - > >> >> 'https://storage.tuxboot.com/buildroot/20241119/x86_64/rootfs.ext4.zst', > >> >> - > >> >> '4b8b2a99117519c5290e1202cb36eb6c7aaba92b357b5160f5970cf5fb78a751') > >> >> + > >> >> 'https://storage.tuxboot.com/buildroot/20260924/x86_64/rootfs.ext4.zst', > >> >> + > >> >> '8e310455b0244414ccff29c507f7ccfd4032e3587cc405e49ab0322738e3e27c') > >> >> > >> >> def test_x86_64(self): > >> >> self.require_accelerator("tcg") > >> >> -- > >> >> 2.47.3 > >> >> > >> > > >> > With regards, > >> > Daniel > >> > >> -- > >> Alex Bennée > >> Virtualisation Tech Lead @ Linaro > >> > > > > With regards, > > Daniel > > -- > Alex Bennée > Virtualisation Tech Lead @ Linaro > With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
