Hi On Wed, Oct 7, 2026 at 11:10 PM Kim, Dongwon <[email protected]> wrote: > > Hi Marc-André, > > > -----Original Message----- > > From: [email protected] <qemu- > > [email protected]> On Behalf Of > > [email protected] > > Sent: Tuesday, August 11, 2026 3:24 AM > > To: [email protected] > > Subject: [PATCH v2 0/3] ui/gtk: Hotkey and fullscreen handling fixes > > > > From: Dongwon Kim <[email protected]> > > > > This series resolves several issues regarding keyboard shortcuts and > > fullscreen > > behavior in the QEMU GTK UI. > > > > 1. Detached (untabified) windows properly support fullscreen and zoom > > accelerators. > > 2. The "Grab Input" accelerator remains functional in fullscreen mode when > > the menubar is hidden. > > 3. Initial fullscreen setup is deferred until the window is properly > > realized to avoid display configuration race conditions. > > > > v2: > > - Return TRUE in accelerator callbacks (gd_accel_grab_input, gd_win_*) to > > comply with the GtkAccelGroupActivate prototype. > > - Restore scale to preferred_scale and trigger gd_update_cursor() on > > fullscreen exit. > > - Deduplicate zoom handling by sharing gd_win_zoom_* across menu > > actions. > > - Guard zoom helpers against NULL / non-GFX consoles. > > - Remove leftover debug fprintf in gd_win_grab. > > > > Dongwon Kim (3): > > ui/gtk: Enable fullscreen and zoom hotkeys for detached windows > > ui/gtk: Register "Grab Input" shortcut to accel_group > > ui/gtk: Defer initial fullscreen activation until window is mapped > > > > ui/gtk.c | 188 ++++++++++++++++++++++++++++++++++++++++++------------- > > 1 file changed, 146 insertions(+), 42 deletions(-) > > > > -- > > 2.43.0 > > > > Friendly ping on this series when you get a chance.
Sorry for the late reply, for some reason I didn't receive the series. It would need a helper gd_is_fullscreen() because 5 functions still only check s->full_screen. Please introduce a preliminary helper for it Second patch looks good. thanks
